-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for the LUKS version selection from GUI #5395
Merged
poncovka
merged 3 commits into
rhinstaller:master
from
poncovka:master-gui_luks_selector_removal
Jan 12, 2024
Merged
Remove support for the LUKS version selection from GUI #5395
poncovka
merged 3 commits into
rhinstaller:master
from
poncovka:master-gui_luks_selector_removal
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All widgets for the LUKS version selection were removed from the Custom Partitioning GUI screen. Use the kickstart support or Blivet GUI to select the LUKS version.
During the interactive partititioning (via the Custom Partitioning GUI screen), make sure that the LUKS version is set to the default one instead of None.
poncovka
temporarily deployed
to
gh-cockpituous
January 5, 2024 16:54
— with
GitHub Actions
Inactive
…alog Move the "Encrypt" checkbox next to the RAID combobox in the Container dialog.
poncovka
temporarily deployed
to
gh-cockpituous
January 5, 2024 17:09
— with
GitHub Actions
Inactive
vojtechtrefny
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/kickstart-test --testtype smoke |
jkonecny12
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All widgets for the LUKS version selection were removed from the "Manual Partitioning"
screen of the GTK-based graphical user interface. The installer will use the
luks2
version by default for all new devices and keep the LUKS version of existing ones. Use
the kickstart support or Blivet GUI to select the LUKS version.