Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the LUKS version selection from GUI #5395

Merged

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jan 5, 2024

All widgets for the LUKS version selection were removed from the "Manual Partitioning"
screen of the GTK-based graphical user interface. The installer will use the luks2
version by default for all new devices and keep the LUKS version of existing ones. Use
the kickstart support or Blivet GUI to select the LUKS version.

All widgets for the LUKS version selection were removed from the Custom
Partitioning GUI screen. Use the kickstart support or Blivet GUI to select
the LUKS version.
During the interactive partititioning (via the Custom Partitioning GUI screen),
make sure that the LUKS version is set to the default one instead of None.
@poncovka
Copy link
Contributor Author

poncovka commented Jan 5, 2024

Here are screenshots with the changes:
luks_version_standard
luks_version_container

…alog

Move the "Encrypt" checkbox next to the RAID combobox in the Container dialog.
@poncovka
Copy link
Contributor Author

poncovka commented Jan 5, 2024

I have fixed the position of the "Encrypt" checkbox in the Container dialog. It looks better this way:
luks_version_container

Copy link
Contributor

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@poncovka
Copy link
Contributor Author

poncovka commented Jan 8, 2024

/kickstart-test --testtype smoke

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks!

@poncovka poncovka merged commit 800e9c3 into rhinstaller:master Jan 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants