Remove the timezone map from the Time & Date spoke #5404
Conversation
Remove the timezone map, so we can drop the dependency on the libtimezonemap package. This package won't be available on some systems in the future.
Update the format of this file to Glade 3.40.
poncovka
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Hello @poncovka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-16 14:59:18 UTC |
|
Redesign with NTP enabled: Redesign with manual time enabled: |
This is looking great @poncovka !! The only thing I would suggest is maybe 3x the padding between the Time Zone region block and the Radio buttons, and between the radio buttons I'd probably do 2x the padding. I believe GTK padding according to the guidelines of this version of GTK was factors of 6. So maybe 18px padding between the two major blocks, and 12px padding between the radio button options. |
Like this? Or the padding should be additional to the current spacing? |
|
@poncovka The 2nd one with more padding - that's great! |
poncovka
force-pushed
the
master-remove_timezone_map
branch
from
1fe1c58
to
59cf8b8
Compare
poncovka
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Ah while we're here, sorry, one quick tweak if not a pain - a little more padding between the date dropdowns and the "/" characters inbetween the widgets... maybe just 6 px? |
Like this? I tried it with two different locales ( |
@poncovka this looks fantastic - how do you feel about it? |
The spoke doesn't look good without the timezone map, so do a little redesign. See the discussion at rhinstaller#5355.
I like is as well. Ok. Let's do that :-) |
poncovka
force-pushed
the
master-remove_timezone_map
branch
from
59cf8b8
to
d401391
Compare
poncovka
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/build-image --boot.iso |
|
Images built based on commit d401391:
Download the images from the bottom of the job status page. |
|
/kickstart-test --testtype smoke |
|
I mourn the loss in fanciness, but it looks good otherwise. |
|
/kickstart-test -t time |
Indeed. I've enjoyed the ease-of-use behind just pointing and clicking. Scrolling through a long list of cities is annoying. The bigger problem I think, though, is that users who are not familiar with city-based time zones (i.e. don't know what city they should be associated with) might have a hard time finding the right one (e.g. a user in Austin needs to know to select Chicago). This is not an improvement for the user, it's taking a step backwards. Why was this removed? |
The timezone map was removed from the Time & Date spoke in the GKT-based user interface
and the spoke was redesigned to accommodate the changes. The installer no longer depends
on the the
libtimezonemappackage.TODO:
time.See: #5355