Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace namespace SHOULD be a template parameter #246

Open
esnible opened this issue Jun 17, 2022 · 0 comments
Open

Trace namespace SHOULD be a template parameter #246

esnible opened this issue Jun 17, 2022 · 0 comments

Comments

@esnible
Copy link
Contributor

esnible commented Jun 17, 2022

It isn't possible to configure the trace namespace without regenerating the templates.

This means that oc process can't alter the namespaces. They aren't configurable.

resources/services/observatorium-traces-template.yaml has { name: 'OBSERVATORIUM_TRACES_NAMESPACE', value: 'observatorium-traces' }, in the Jsonnet.

It gets substituted in the correct places by resources/services/observatorium-template.yaml

- --experimental.traces.read.endpoint-template=http://observatorium-jaeger-{tenant}-query.${OBSERVATORIUM_TRACES_NAMESPACE}.svc.cluster.local:16686/
...
--experimental.traces.read.endpoint-template=http://observatorium-jaeger-{tenant}-query.${OBSERVATORIUM_TRACES_NAMESPACE}.svc.cluster.local:16686/

The problem is that the substitution happens when the Templates are being made. Rather than being something that is fixed during template generation, the traces namespace SHOULD become an OpenShift template parameter similar to NAMESPACE, OPENTELEMETRY_OPERATOR_NAMESPACE or JAEGER_OPERATOR_NAMESPACE.

cc @pavolloffay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant