Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min ready seconds inc #679

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Feb 6, 2024

  1. Increase minReadySeconds setting on Thanos receive from 60s -> 120s
  2. Add flag to ensure only ready replicas are added to the hashring when we scale up

@moadz
Copy link
Contributor

moadz commented Feb 6, 2024

Just so we don't forget this later, are you happy to do this for receive-ingestors as well on the rhobs namespace go-configs?

@philipgough philipgough merged commit bdf670e into rhobs:main Feb 6, 2024
3 checks passed
@philipgough philipgough deleted the min-ready-seconds-inc branch February 6, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants