Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Rails < 5 and Ruby < 2.5 #66

Open
7 tasks
skalee opened this issue Jun 2, 2020 · 4 comments
Open
7 tasks

Remove support for Rails < 5 and Ruby < 2.5 #66

skalee opened this issue Jun 2, 2020 · 4 comments

Comments

@skalee
Copy link
Contributor

skalee commented Jun 2, 2020

Let's cut off some ballast. Legacy code means trouble.

There's no point in reintroducing Rails 4.2 support. Although it still receives occasional security updates (May 2020), it's really old and two major versions behind the latest Rails.

Let's drop support for some oldest Rubies too. There is no point in maintaining compatibility with Ruby 2.3, which has reached its end of life over a year ago (on 2019-03-31), and is causing problems due to incompatibility with current versions of mysql2 gem. We should drop support for Ruby 2.4 too — although it isn't problematic now,

There is no good point in maintaining compatibility with Ruby 2.4, which has reached its end of life about two months ago (2020-03-31). Although all works now, we can expect some problems in future, especially with native code in database backends.

Perhaps we should drop support for Ruby 2.5 too, I haven't decided yet. It is still supported, but fairly old and is scheduled to reach its end of life next year (on 2021-03-31). Dropping support now means not having to do it in near future. It's good to do one big breaking change rather than two smaller ones.

TODO

  • Remove old versions from test matrix.
  • Remove any logic which was for Rails 4 solely.
  • Remove any logic which was for older Rubies solely.
  • Remove support for mysql gem (not to be confused with mysql2)
  • Bump Ruby and Rails version constraints in the gemspec.
  • Update tools configuration (e.g. Rubocop)
  • Mention in the README that the original gem supports older software.
@ronaldtse
Copy link
Contributor

ronaldtse commented Jun 2, 2020

Agree with @skalee , let's do that. Ping @ribose-jeffreylau any objections?

@skalee
Copy link
Contributor Author

skalee commented Jun 2, 2020

Also support for mysql gem should be removed. This is a very old adapter gem (last release in 2013) which has been superseded with mysql2 gem.

@ribose-jeffreylau
Copy link
Contributor

Agreed.
Let's drop support for mysql gem as well, like @skalee said.

@ronaldtse
Copy link
Contributor

This is somewhat addressed in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants