Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIBNEREON_LIBRARY is not defined as CMake target #40

Closed
maxirmx opened this issue Jan 11, 2022 · 1 comment · Fixed by #41
Closed

LIBNEREON_LIBRARY is not defined as CMake target #40

maxirmx opened this issue Jan 11, 2022 · 1 comment · Fixed by #41
Assignees
@maxirmx

Comments

@maxirmx
Copy link
Collaborator

maxirmx commented Jan 11, 2022

There is a problem here: https://github.com/riboseinc/libnereon/blob/master/src/CMakeLists.txt

LIBNEREON_LIBRARY is not defined as CMake target at all. Unix and MacOS versions of cmake somehow manage to create correct build sequence, but MSYS version fails. So the fix is required at libneron source.

Originally posted by @maxirmx in riboseinc/retrace#421 (comment)
@maxirmx maxirmx changed the title There is a problem here: https://github.com/riboseinc/libnereon/blob/master/src/CMakeLists.txt LIBNEREON_LIBRARY is not defined as CMake target Jan 11, 2022
@ronaldtse
Copy link

@maxirmx thanks for reporting this. Would you be able to help fix this? Thanks!

@maxirmx maxirmx self-assigned this Jan 12, 2022
@maxirmx maxirmx linked a pull request Jan 12, 2022 that will close this issue
MSYS build fixes #41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxirmx maxirmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSYS build fixes riboseinc/libnereon
2 participants
@ronaldtse @maxirmx