Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git submodule instead of using ssh to clone metanorma.com #11

Closed
kwkwan opened this issue Jul 3, 2018 · 2 comments
Closed

Use git submodule instead of using ssh to clone metanorma.com #11

kwkwan opened this issue Jul 3, 2018 · 2 comments

Comments

@kwkwan
Copy link
Contributor

kwkwan commented Jul 3, 2018

It is simpler to use git submodule for project site instead of writing a script to clone, and much easier to make production deployment work too.

@strogonoff
Copy link
Contributor

strogonoff commented Jul 11, 2018

@kwkwan

I’m not sure I see a problem due to which production deployments don’t “work” with cloning. What submodules could indeed help with is reducing build time and eliminating some of the build logic. The choice to go with cloning was made to avoid the need to commit changes each time a subproject changes, since build time is considered less important than convenience of maintaining up-to-date docs.

It doesn’t belong in this project but it’s something to consider, so I filed a corresponding issue against the corresponding plugin gem (riboseinc/jekyll-theme-open-project-helpers#1). Thank you!

@strogonoff
Copy link
Contributor

(To clarify, this is definitely on the table, I’m just moving further discussion on this under the abovementioned ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants