Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only iv column and not salt by default #18

Closed
ribose-jeffreylau opened this issue Mar 8, 2019 · 1 comment · Fixed by #19
Closed

Use only iv column and not salt by default #18

ribose-jeffreylau opened this issue Mar 8, 2019 · 1 comment · Fixed by #19
Assignees

Comments

@ribose-jeffreylau
Copy link
Contributor

https://github.com/attr-encrypted/attr_encrypted#the-mode-option

Our dependency on attr_encrypted means this project should act on deprecations on modes involving salt.

Since we haven't released any official versions, I think it's safe to directly remove mentions of salt in the code, e.g., db/migrate/20180822000001_create_schema.rb, without risking breakage of other people's production code.

@ribose-jeffreylau ribose-jeffreylau self-assigned this Mar 8, 2019
@ronaldtse
Copy link

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants