Merge pull request #36 from ricardo-ch/log-error-when-infinite-retry

log error when there is an infinite retry pattern
ricardo-ch · Apr 23, 2024 · ecf0569 · ecf0569
2 parents 7056d31 + f6a9d22
commit ecf0569
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/listener.go b/listener.go
@@ -348,6 +348,8 @@ func (l *listener) handleMessageWithRetry(ctx context.Context, handler Handler,
 		time.Sleep(*handler.Config.DurationBeforeRetry)
 		if retries != InfiniteRetries {
 			retries--
+		} else {
+			ErrorLogger.Printf("Error for message with infinite retry %+v: ", err)
 		}
 		return l.handleMessageWithRetry(ctx, handler, msg, retries)
 	}

diff --git a/listener_test.go b/listener_test.go
@@ -230,6 +230,9 @@ func Test_ConsumeClaim_Message_Error_WithErrorTopic(t *testing.T) {
 		Config:    testHandlerConfig,
 	}
 
+	defaultLogger := ErrorLogger
+	defer func() { ErrorLogger = defaultLogger }()
+
 	errorLogged := false
 	mockLogger := &mocks.StdLogger{}
 	mockLogger.On("Printf", mock.Anything, mock.Anything).Return().Run(func(mock.Arguments) {
@@ -280,6 +283,9 @@ func Test_ConsumeClaim_Message_Error_WithPanicTopic(t *testing.T) {
 		Config:    testHandlerConfig,
 	}
 
+	defaultLogger := ErrorLogger
+	defer func() { ErrorLogger = defaultLogger }()
+
 	errorLogged := false
 	mockLogger := &mocks.StdLogger{}
 	mockLogger.On("Printf", mock.Anything, mock.Anything).Return().Run(func(mock.Arguments) {
@@ -335,6 +341,9 @@ func Test_ConsumeClaim_Message_Error_WithHandlerSpecificRetryTopic(t *testing.T)
 		},
 	}
 
+	defaultLogger := ErrorLogger
+	defer func() { ErrorLogger = defaultLogger }()
+
 	errorLogged := false
 	mockLogger := &mocks.StdLogger{}
 	mockLogger.On("Printf", mock.Anything, mock.Anything).Return().Run(func(mock.Arguments) {
@@ -365,6 +374,9 @@ func Test_handleErrorMessage_OmittedError(t *testing.T) {
 
 	l := listener{}
 
+	defaultLogger := ErrorLogger
+	defer func() { ErrorLogger = defaultLogger }()
+
 	errorLogged := false
 	mockLogger := &mocks.StdLogger{}
 	mockLogger.On("Printf", "Omitted message: %+v", mock.Anything).Return().Run(func(mock.Arguments) {