Add exponential backoff possibility in case of retries #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErwanVP
requested review from
EdouardBavoux and
EtienneGuerlais
and removed request for
EdouardBavoux
ErwanVP
force-pushed
the
add_exponential_backoff
branch
from
772e112 to
93b80fd
Compare
README.md
Outdated
| @@ -128,6 +128,12 @@ return errors.Wrap(kafka.ErrNonRetriable, err.Error()) | |||
| // This error will also not be retried | |||
| return kafka.ErrNonRetriable | |||
| ``` | |||
|
|
|||
| #### exponential backoff | |||
| You can activate it but setting `ExponentialBackoff` config variable as true. You can set this properties as global, you have to use the configuration per-topic. This configuration is useful in case of infinite retry configuration. | |||
There was a problem hiding this comment.
typo : You can activate it by setting...
README.md
Outdated
|
|
||
| #### exponential backoff | ||
| You can activate it but setting `ExponentialBackoff` config variable as true. You can set this properties as global, you have to use the configuration per-topic. This configuration is useful in case of infinite retry configuration. | ||
| The exponential backoff algorithm is define like this. |
listener.go
Outdated
| time.Sleep(*handler.Config.DurationBeforeRetry) | ||
| if exponentialBackoff { | ||
| backoffDuration := calculateExponentialBackoffDuration(retryNumber, handler.Config.DurationBeforeRetry) | ||
| Logger.Printf("exponential backoff enable we will retry in %s", backoffDuration) |
There was a problem hiding this comment.
typo : exponential backoff enabled : we will retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature could be useful in case of infinite retry. In the case of listener issues, this avoids making too many requests.