remove istio sidecar clu limit (#27)

* removing just default cpu limit
ricardo-ch · Feb 18, 2021 · 3acc108 · 3acc108
1 parent 7fcaccf
commit 3acc108
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/charts/imaginary/Chart.yaml b/charts/imaginary/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: "1.2.4"
 description: Deploy imaginary to process pictures on the fly
 name: imaginary
-version: 0.1.3
+version: 0.1.4
 home: https://github.com/h2non/imaginary
 sources:
   - https://github.com/ricardo-ch/helm-charts/tree/main/charts/imaginary
@@ -15,7 +15,7 @@ keywords:
   - h2non
 annotations:
   artifacthub.io/changes: |
-    - Adding configuration for istio sidecar(injection and resources). Support istio 1.8+ annotations.
+    - Removing default value for Istio CPU limit
   artifacthub.io/images: |
     - name: imaginary
       image: h2non/imaginary:1.2.4
diff --git a/charts/imaginary/README.md b/charts/imaginary/README.md
@@ -1,6 +1,6 @@
 # Imaginary
 
-![Version: 0.1.3](https://img.shields.io/badge/Version-0.1.3-informational?style=flat-square) ![AppVersion: 1.2.4](https://img.shields.io/badge/AppVersion-1.2.4-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg) [![License](https://img.shields.io/github/license/ricardo-ch/helm-charts)](https://github.com/ricardo-ch/helm-charts/blob/main/LICENSE)
+![Version: 0.1.4](https://img.shields.io/badge/Version-0.1.4-informational?style=flat-square) ![AppVersion: 1.2.4](https://img.shields.io/badge/AppVersion-1.2.4-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg) [![License](https://img.shields.io/github/license/ricardo-ch/helm-charts)](https://github.com/ricardo-ch/helm-charts/blob/main/LICENSE)
 
 This chart installs [Imaginary](https://github.com/h2non/imaginary).
 
@@ -34,7 +34,7 @@ Simply add this Chart repository to Helm:
 | image | string | `"h2non/imaginary:1.2.4"` | Docker image repository to pull it. |
 | imagePullPolicy | string | `"IfNotPresent"` | imagePullPolicy used by k8s |
 | istio.cpu | string | `"10m"` | istio sidecar cpu request |
-| istio.cpuLimit | string | `"10m"` | istio sidecar cpu request limit |
+| istio.cpuLimit | string | `nil` | istio sidecar cpu request limit |
 | istio.inject | bool | `false` | istio sidecar configuration, enable injecting sidecar |
 | istio.memory | string | `"128Mi"` | istio sidecar memory request |
 | istio.memoryLimit | string | `"128Mi"` | istio sidecar memory limit |

diff --git a/charts/imaginary/templates/deployment.yaml b/charts/imaginary/templates/deployment.yaml
@@ -26,7 +26,9 @@ spec:
 {{- if .Values.istio.inject }}
         sidecar.istio.io/inject: {{ quote .Values.istio.inject }}
         sidecar.istio.io/proxyCPU: {{ .Values.istio.cpu }}
+        {{- if .Values.istio.cpuLimit }}
         sidecar.istio.io/proxyCPULimit: {{ .Values.istio.cpuLimit }}
+        {{- end }}
         sidecar.istio.io/proxyMemory: {{ .Values.istio.memory }}
         sidecar.istio.io/proxyMemoryLimit: {{ .Values.istio.memoryLimit }}
 {{- end }}

diff --git a/charts/imaginary/values.yaml b/charts/imaginary/values.yaml
@@ -68,7 +68,8 @@ istio:
   # -- istio sidecar cpu request
   cpu: 10m
   # -- istio sidecar cpu request limit
-  cpuLimit: 10m
+  cpuLimit:
+
 
 # -- estimated time to propagate the information the pod is not part of the service anymore
 gracefulShutdownDelaySeconds: