fix quote issue and remove web port (#9)

ricardo-ch · Oct 7, 2020 · 48fd777 · 48fd777
1 parent 42eae5b
commit 48fd777
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/charts/promlens/Chart.yaml b/charts/promlens/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: promlens
-version: 1.0.0
+version: 1.0.1
 description: This Chart installs and configures PromLens
 home: https://promlens.com
 icon: https://promlens.com/apple-touch-icon.png

diff --git a/charts/promlens/README.md b/charts/promlens/README.md
@@ -1,6 +1,6 @@
 # PromLens
 
-![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg)
+![Version: 1.0.1](https://img.shields.io/badge/Version-1.0.1-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg)
 
 This chart installs [PromLens](https://promlens.com/) from [PromLabs](https://promlabs.com/).
 
@@ -34,7 +34,6 @@ Simply add this Chart repository to Helm:
 | config.shared_links.gcs.storage_account | string | `nil` | Google Cloud Storage Account |
 | config.web.default_prometheus_url | string | `nil` | The default Prometheus URL to load PromLens with. |
 | config.web.external_url | string | `nil` | The URL under which PromLens is externally reachable (for example, if PromLens is served via a reverse proxy). Used for generating relative and absolute links back to PromLens itself. If the URL has a path portion, it will be used to prefix all HTTP endpoints served by PromLens. If omitted, relevant URL components will be derived automatically. |
-| config.web.listen_address | int | `8080` | The address to listen on for the web API. |
 | deployment.image | string | `"promlabs/promlens"` | PromLens Conatiner Image |
 | deployment.replicas | int | `1` | Number of replicas |
 | deployment.version | string | `"latest"` | PromLens Container Image Version |

diff --git a/charts/promlens/templates/deployment.yaml b/charts/promlens/templates/deployment.yaml
@@ -28,12 +28,11 @@ spec:
           - --grafana.url={{ .Values.config.grafana.url }}
           - --grafana.api-token={{ .Values.config.grafana.api_token }}
           {{- end }}
-          - --web.listen-address=":{{ .Values.config.web.listen_address }}"
           {{- if .Values.config.web.external_url }}
-          - --web.external-url={{ .Values.config.web.external_url | quote }}
+          - --web.external-url={{ .Values.config.web.external_url }}
           {{- end }}
           {{- if .Values.config.web.default_prometheus_url }}
-          - --web.default-prometheus-url={{ .Values.config.web.default_prometheus_url | quote }}
+          - --web.default-prometheus-url={{ .Values.config.web.default_prometheus_url }}
           {{- end }}
           - --log.level={{ .Values.config.log.level }}
           - --log.format={{ .Values.config.log.format }}

diff --git a/charts/promlens/templates/service.yaml b/charts/promlens/templates/service.yaml
@@ -10,8 +10,8 @@ metadata:
 spec:
   ports:
   - name: http
-    port: {{ .Values.config.web.listen_address }}
+    port: 8080
     protocol: TCP
-    targetPort: {{ .Values.config.web.listen_address }}
+    targetPort: 8080
   selector:
     app: {{ template "promlens.name" . }}
diff --git a/charts/promlens/values.yaml b/charts/promlens/values.yaml
@@ -28,8 +28,6 @@ config:
       bucket: "promlens"
 
   web:
-    # -- The address to listen on for the web API.
-    listen_address: 8080
     # -- The URL under which PromLens is externally reachable (for example, if PromLens is served via a reverse proxy). Used for generating relative and absolute links back to PromLens itself. If the URL has a path portion, it will be used to prefix all HTTP endpoints served by PromLens. If omitted, relevant URL components will be derived automatically.
     external_url:
     # -- The default Prometheus URL to load PromLens with.