Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #75

Open
GitHubMLee opened this issue Sep 21, 2023 · 2 comments
Open

Enhancements #75

GitHubMLee opened this issue Sep 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@GitHubMLee
Copy link

This is not an issue but a feature enhancement. I use this tool a lot - it's one of the best QGIS plugins in my opinion (thank you Riccardo!). However, it could be enhanced with the following:

  • Upgrading to connect with the HERE v8 routing engine (https://isoline.router.hereapi.com/v8/isolines?). This would require some changes to the coding to use new format API specs - eg 'transportMode' rather than 'Mode'
  • Enabling other API parameters such as 'optimizeFor' and 'shape[maxPoints]' to control granularity of output
  • Retaining attributes of the original features (ie creating the table join as part of the output), preferably with the choice of which attributes to retain.

Unfortunately I have no coding experience and having gone into the hqgis.py file I am lost as to how to alter the code. But if others could help, this could become an incredible tool!

Thanks
Matt

@GitHubMLee GitHubMLee changed the title Additional parameters Enhancements Sep 21, 2023
@riccardoklinger
Copy link
Owner

Hi Matt, my latest set of commits is migtrationg everything to v8 or 7.2 (irsoline routing is still 7.2, isn't it?)
regarding the last point: every result layer which has a origin layer will have a field called origin_id and this is the basis for every join. Or do you think it would be better to allow the user to set a "keep this field in the result dataset please"?
The new version of the plugin is available via the plugin manager

@riccardoklinger riccardoklinger added the enhancement New feature or request label Oct 8, 2023
@riccardoklinger riccardoklinger self-assigned this Oct 8, 2023
@GitHubMLee
Copy link
Author

GitHubMLee commented Oct 8, 2023

Riccardo, thanks for the latest update. Does this implement v8 for isolines?
I'm aware that the origin-id field is a usable join field, but I do think that the ability to retain other fields in the results would make it easier for users to analyse the results.
In relation to my second suggestion (opening up other parameters such as those that affect the resulting shape of the isoline) this would be a fantastic addition. Is this something you are likely to work on for future updates?
Thanks again for a great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants