-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: implicit dependency on build.rs
?
#4
Comments
I need to think about this properly, but at the moment, this library could be used to build anything, including non-rust stuff. Might it be better to create another library that re-exports stuff from this library, and adds any useful rust stuff, like the above? |
@derekdreery
Oh, I missed this point.
Is it too complicated, why not just add method like |
ok I could do that. |
@derekdreery
Great, I would like integrate |
I've added a function in commit e2009f3 that adds a dependency to all previously added files, so at the end of a chain, you can do .add_dep_to_all("build.rs") Does this solve your problem? |
@derekdreery Yes, thank you. |
@derekdreery I did additional testing, and see one bad thing, depgraph gives Because of it is inconvinient in each rule add |
OK, so maybe instead of adding this file as a dependency, it could go into a separate global pool of files that will always trigger rebuilds, but don't inform the build functions of their presence. |
At now if you change something in
build.rs
,rust-lang/cargo automaticaly run
build.rs
,but rules run only you explicity add
build.rs
to dependency graph.Of course explicity better then implicity, but I can not think of usage scenario
where you not need dependency from
build.rs
?So why not add implicity rule that any rule depend also from
build.rs
?The text was updated successfully, but these errors were encountered: