-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryMatcher Case Sensitiviy #134
Comments
I agree! not only for parameters but also for urls and json-strings would be nice |
I wonder if a Is this something you would accept in a PR? /// <summary>
/// Provides options on how to match query strings.
/// </summary>
public sealed class QueryStringMatcherOptions
{
/// <summary>
/// Constructs a new instance of QueryStringMatcherOptions using the default ordinal comparison on keys and values.
/// </summary>
public QueryStringMatcherOptions() : this(StringComparer.Ordinal, StringComparer.Ordinal)
{
}
/// <summary>
/// Constructs a new instance of QueryStringMatcherOptions using the default ordinal comparison on keys and values.
/// </summary>
public QueryStringMatcherOptions(IEqualityComparer<string>? key = null, IEqualityComparer<string>? value = null)
{
KeyComparer = key ?? StringComparer.Ordinal;
ValueComparer = value ?? StringComparer.Ordinal;
}
/// <summary>
/// The comparer to use for keys
/// </summary>
public IEqualityComparer<string> KeyComparer { get; }
/// <summary>
/// The comparer to use for values
/// </summary>
public IEqualityComparer<string> ValueComparer { get; }
} |
Could you explain your use case on the problem you are trying to solve by performing a case insensitive comparison? Knowing the problem you are trying to solve will ensure any features developed will match the problem you are trying to solve. |
Would it be possible to add an option to make the QueryMatcher check for parameter keys in a case insensitive?
The text was updated successfully, but these errors were encountered: