Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe blocks without hurting performance #24

Open
richox opened this issue Nov 18, 2021 · 2 comments
Open

Remove unsafe blocks without hurting performance #24

richox opened this issue Nov 18, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@richox
Copy link
Owner

richox commented Nov 18, 2021

No description provided.

@richox richox added the help wanted Extra attention is needed label Nov 18, 2021
@18o
Copy link

18o commented Nov 18, 2021

is there any good idea for removing these unsafe code?

@richox
Copy link
Owner Author

richox commented Nov 25, 2021 •
edited
Loading

is there any good idea for removing these unsafe code?

@18o most unsafe is used for avoiding boundary checks by using unchecked_index. i think many of them are not performance critical and can be replaced with normal slice indexing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richox @18o