DOMException not catched

[Phyks]

Hi,

When running a webpage using NoSleep in the latest Chromium build for Android, I get a

DOMException: Failed to load because no supported source was found.

Which is never caught. I tracked it down to https://github.com/richtr/NoSleep.js/blob/master/src/index.js#L37 where it should be caught on play. I guess actually the enable method might return the play Promise so that user can deal with issue the way they want, no?

For the deeper underneath issue raising this exception, it seems Chromium on Android has no support for MP4 video files (not sure whether Chrome does). Replacing https://github.com/richtr/NoSleep.js/blob/master/src/media.js by a WebM converted video works well!

Maybe NoSleep could provide the source file in both MP4 and WebM and let the browser play the best fitted one?

Thanks!

[richtr]

It's a good idea and I think this relates to discussion @ #47.

This library has used WebM files in the past and I aim to resurrect that usage in an upcoming release.

Maybe NoSleep could provide the source file in both MP4 and WebM and let the browser play the best fitted one?

I think this is a good idea. Provide two video sources and let the browser pick one. Regarding #47 I think the WebM video should not include an audio track.

I already created the perfect WebM video file with no audio track to use a while ago btw ;)

From mathiasbynens/small#10:

Single-frame 8×8px WebM video without sound.
185 bytes

https://github.com/mathiasbynens/small/blob/master/webm.webm

I will continue looking in to this.

[richtr]

Fixed by #58.

This will now be released as v0.9.0.

[Phyks]

Great! Thanks a lot!