Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Problem.shouldSkip() for large, new projects #384

Open
RBusarow opened this issue Feb 18, 2022 · 0 comments
Open
Labels
feature New feature or request

Comments

@RBusarow
Copy link
Member

The current implementation re-parses the build file for every single finding. This is extremely time-consuming on huge projects with lots of findings.

Some observations:

  • "inherited" findings can't really be suppressed as it is, since the declaration is for a different module (and there can be many). Either that suppression method should be updated, or the check should be skipped for that and any similar type.
  • those annotations/comments won't be added mid-task, so the amount of parsing being done is redundant.
    • One fix could be to scan each build file once for the annotations/comments, and set a flag for that file once to say if it can be skipped.
@RBusarow RBusarow added the feature New feature or request label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant