Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Needs support for Prettier version 3 #312

Open
w3bdesign opened this issue Jul 5, 2023 · 4 comments
Open

Needs support for Prettier version 3 #312

w3bdesign opened this issue Jul 5, 2023 · 4 comments

Comments

@w3bdesign
Copy link

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/prettier
npm ERR!   dev prettier@"^3.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer prettier@"^2.0.0" from [email protected]
npm ERR! node_modules/sanity-codegen
npm ERR!   dev sanity-codegen@"^0.9.8" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/prettier
npm ERR!   peer prettier@"^2.0.0" from [email protected]
npm ERR!   node_modules/sanity-codegen
npm ERR!     dev sanity-codegen@"^0.9.8" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/dae811/764f68/cache/others/npm/_logs/2023-07-05T15_01_05_455Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/dae811/764f68/cache/others/npm/_logs/2023-07-05T15_01_05_455Z-debug-0.log
w3bdesign added a commit to w3bdesign/sanity-codegen that referenced this issue Jul 5, 2023
@w3bdesign
Copy link
Author

Should be resolved in #313

@Ne-Ne
Copy link

Ne-Ne commented Jul 23, 2023

@w3bdesign I saw the PR that resolves the above, thanks for getting on this.

Are there plans to merge this back into main?

I am also curious why prettier is specified within peerDependencies as it breaks my project upgrade to v3.

@mi-na-bot
Copy link

@Ne-Ne The last release or a usable version was almost two years ago, so probably not soon! There is really nothing wrong with Prettier v2...

@Ne-Ne
Copy link

Ne-Ne commented Aug 5, 2023

I don't have anything against Prettier v2 @MinervaBot.

However, this peerDependencies reference blocks consumers from upgrading tools. I currently run Renovate so I get auto-package updates. It is frustrating that my PR queue now has errors due to this blocking dep.

Ironically the Prettier package serves no purpose for npm package consumers and is only an internal tool.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants