Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-result= only checks triggered events if the user expects them #16

Open
Heliosmaster opened this issue Jan 11, 2016 · 1 comment

Comments

@Heliosmaster
Copy link
Member

In here the function command-result= will only check for additional events if the user expects them.

Maybe this is completely intentional, because you want these "triggered" events to be quite independent, but this has the potential of making a test pass when the user does not expect any triggered events but there are. So it's not really the full result of the command anymore, at that point.

@joodie
Copy link
Contributor

joodie commented Jan 11, 2016

This was intentional to prevent breaking the API; it used to not check triggered events at all. I'm OK with changing this if you put in a merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants