Add more tests for redundant parentheses

rillig · Jan 20, 2024 · 62dcce3 · 62dcce3
1 parent 76efe50
commit 62dcce3
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/v23/mkcondchecker_test.go b/v23/mkcondchecker_test.go
@@ -412,6 +412,16 @@ func (s *Suite) Test_MkCondChecker_checkRedundantParentheses(c *check.C) {
 	test(
 		".if (1) || 2",
 		nil...)
+
+	test(
+		".if (!0)",
+		"NOTE: filename.mk:2: Parentheses "+
+			"around the outermost condition are redundant.")
+
+	test(
+		".if (!empty(${VARNAME:L}:Mpattern))",
+		"NOTE: filename.mk:2: Parentheses "+
+			"around the outermost condition are redundant.")
 }
 
 func (s *Suite) Test_MkCondChecker_checkAnd(c *check.C) {