-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try assess on star incase it crashes. #10
Comments
It definitely crashes. There are no safeguards for computing metrics that require there to be ground truth positives available. The true dag for the star cases has no examples of true edges that don't connect to the latent space Separate question: how can we evaluate edges to the latent space? We'd have to match the inferred nodes to the latent nodes in some way. |
the problem is if the true vs estimated latent dimensionality is different. |
not sure how you want to define the performance when there are no positive cases. We could do something different in those cases. |
I think the solution is to only report metrics that don't crash, e.g. lift (for FNR, for example). This can be easily done by wrapping each metric inside try/catch |
also skip if there is no true network provided. |
See separate issue that I've just closed - assess() will plot corrplot if true and inferred latent spaces are available, and will exit after that if the true network is not available. |
lift is defined (in performance functions) as P(Yhat = + | Y = +)/P(Yhat = +). but the conditional is only defined if P(Y=+) >0. So in the star case it will be undefined. Same with TPR so AUC or prAUC can't be estimated either. But I can show the other stuff instead. |
No description provided.
The text was updated successfully, but these errors were encountered: