Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the assess() function #3

Open
rimorob opened this issue Mar 15, 2023 · 7 comments
Open

Fix the assess() function #3

rimorob opened this issue Mar 15, 2023 · 7 comments
Assignees

Comments

@rimorob
Copy link
Owner

rimorob commented Mar 15, 2023

Plot AUCs and PR-AUCs not as dots but on the same AUC plot with error bars, using either/both of ROCR and PROC

@fkgruber
Copy link
Collaborator

we want:

  • pvalues
  • lift curves

@fkgruber
Copy link
Collaborator

Hi Boris @rimorob
I have a first version of the assess plotting. It plots what you have now which is auc vs iteration and also saves the roc curves at each iteration as:

image

One question I have is regarding the p-value. THe ROCR test function allows to compare 2 roc curves. Were you thinking to compare the ROC of the true vs each iteration or each iteration with estimated latent variable vs the roc curve if the 1st iteration (ignoring latent variables)?

@rimorob
Copy link
Owner Author

rimorob commented Mar 19, 2023

Yes, I think AUC vs the true network (minus the edges crossing into the latent space) would be used as the basis for comparison

Looks nice!

@rimorob
Copy link
Owner Author

rimorob commented Apr 2, 2023

Fred, is this fully finished?

@fkgruber
Copy link
Collaborator

fkgruber commented Apr 6, 2023

I think I'm missing the p-value

@fkgruber
Copy link
Collaborator

fkgruber commented Apr 7, 2023

Yes, I think AUC vs the true network (minus the edges crossing into the latent space) would be used as the basis for comparison

Looks nice!

Actually roc.test works by providing 2 roc objects which mean we need 2 estimated network vs the true.
one option comparing the network from having the true latent variable in vs the last estimated network. Perhaps we should learn this oracle network by default to use as reference at the end

@fkgruber
Copy link
Collaborator

fkgruber commented Apr 8, 2023

I will let assess have an argument with the oracle performance so we can show pvalues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants