From 4b4a8b9fb7392e1f8bfa995c1223a572284d2d2c Mon Sep 17 00:00:00 2001 From: Alan Zou Date: Thu, 12 Sep 2024 13:31:19 +0800 Subject: [PATCH] fix(List, Menu): [juno-core] remove not need class --- .../__stories__/__snapshots__/Card.story.tsx.snap | 1 - .../__stories__/__snapshots__/DnD.story.tsx.snap | 1 - .../__snapshots__/DnDList.story.tsx.snap | 1 - .../__snapshots__/DnDListPortal.story.tsx.snap | 1 - .../__stories__/__snapshots__/List.story.tsx.snap | 1 - .../__snapshots__/ListExamples.story.tsx.snap | 2 -- .../__snapshots__/ListItem.story.tsx.snap | 6 ------ .../__snapshots__/ListItemExamples.story.tsx.snap | 2 -- .../List/ListItem/styles/ListItemStyle.tsx | 13 +++++-------- .../__snapshots__/ListItemAvatar.story.tsx.snap | 1 - .../__snapshots__/ListItemIcon.story.tsx.snap | 1 - .../ListItemSecondaryAction.story.tsx.snap | 1 - .../__snapshots__/ListItemText.story.tsx.snap | 1 - .../__snapshots__/ListSubheader.story.tsx.snap | 1 - .../__stories__/__snapshots__/Menu.story.tsx.snap | 1 - .../__snapshots__/MenuItem.story.tsx.snap | 7 ------- .../__snapshots__/MenuItemExamples.story.tsx.snap | 15 --------------- .../__snapshots__/MenuList.story.tsx.snap | 1 - .../__snapshots__/MenuListExamples.story.tsx.snap | 2 -- .../__snapshots__/SubMenu.story.tsx.snap | 1 - sync-github.json | 2 +- 21 files changed, 6 insertions(+), 56 deletions(-) diff --git a/packages/juno-core/src/components/Card/Card/__stories__/__snapshots__/Card.story.tsx.snap b/packages/juno-core/src/components/Card/Card/__stories__/__snapshots__/Card.story.tsx.snap index 6d5cb976..c0796cb2 100644 --- a/packages/juno-core/src/components/Card/Card/__stories__/__snapshots__/Card.story.tsx.snap +++ b/packages/juno-core/src/components/Card/Card/__stories__/__snapshots__/Card.story.tsx.snap @@ -405,7 +405,6 @@ exports[`Storyshots 🚀 Cleanup Components/Cards/Card Card Examples 1`] = ` color: #121212; } -.c21.RcListItem-focusVisible, .c21.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnD.story.tsx.snap b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnD.story.tsx.snap index b7fca9b9..ce6e8569 100644 --- a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnD.story.tsx.snap +++ b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnD.story.tsx.snap @@ -58,7 +58,6 @@ exports[`Storyshots 🚀 Cleanup Components/DnD DnD 1`] = ` color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDList.story.tsx.snap b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDList.story.tsx.snap index 8216f06a..312bdcf3 100644 --- a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDList.story.tsx.snap +++ b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDList.story.tsx.snap @@ -17,7 +17,6 @@ exports[`Storyshots 🚀 Cleanup Components/DnD/Dnd Examples/Multiple list Multi color: #121212; } -.c1.RcListItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDListPortal.story.tsx.snap b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDListPortal.story.tsx.snap index 89347798..8ee9398f 100644 --- a/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDListPortal.story.tsx.snap +++ b/packages/juno-core/src/components/DnD/__stories__/__snapshots__/DnDListPortal.story.tsx.snap @@ -17,7 +17,6 @@ exports[`Storyshots 🚀 Cleanup Components/DnD/Dnd Examples/Multiple list/Multi color: #121212; } -.c2.RcListItem-focusVisible, .c2.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/List/__stories__/__snapshots__/List.story.tsx.snap b/packages/juno-core/src/components/List/List/__stories__/__snapshots__/List.story.tsx.snap index 66b0c4a8..a4962db1 100644 --- a/packages/juno-core/src/components/List/List/__stories__/__snapshots__/List.story.tsx.snap +++ b/packages/juno-core/src/components/List/List/__stories__/__snapshots__/List.story.tsx.snap @@ -17,7 +17,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/List List 1`] = ` color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/List/__stories__/__snapshots__/ListExamples.story.tsx.snap b/packages/juno-core/src/components/List/List/__stories__/__snapshots__/ListExamples.story.tsx.snap index a15f8143..7a305545 100644 --- a/packages/juno-core/src/components/List/List/__stories__/__snapshots__/ListExamples.story.tsx.snap +++ b/packages/juno-core/src/components/List/List/__stories__/__snapshots__/ListExamples.story.tsx.snap @@ -133,7 +133,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/List Examples List With Contro color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -557,7 +556,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/List Examples Simple List 1`] color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItem.story.tsx.snap b/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItem.story.tsx.snap index 292cb467..fb3f8160 100644 --- a/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItem.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItem.story.tsx.snap @@ -18,7 +18,6 @@ Array [ color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -167,7 +166,6 @@ Array [ color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -321,7 +319,6 @@ Array [ color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -476,7 +473,6 @@ Array [ background-color: rgba(102,102,102,0.05); } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -631,7 +627,6 @@ Array [ background-color: rgba(60,153,73,0.05); } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -786,7 +781,6 @@ Array [ background-color: rgba(255,136,0,0.05); } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItemExamples.story.tsx.snap b/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItemExamples.story.tsx.snap index ddc32910..76c4f1ee 100644 --- a/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItemExamples.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItem/__stories__/__snapshots__/ListItemExamples.story.tsx.snap @@ -412,7 +412,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItem Examples Multiple-Lin color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -1816,7 +1815,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItem Examples Single-Line color: #121212; } -.c1.RcListItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItem/styles/ListItemStyle.tsx b/packages/juno-core/src/components/List/ListItem/styles/ListItemStyle.tsx index fe7b3c67..a48753c9 100644 --- a/packages/juno-core/src/components/List/ListItem/styles/ListItemStyle.tsx +++ b/packages/juno-core/src/components/List/ListItem/styles/ListItemStyle.tsx @@ -64,14 +64,11 @@ export const sharedListItemStyle: RcThemedStyled< background-color: ${setAlpha(baseColor, 0.05)}; `}; - &.${ - // mui focus visible have issue in old version, we use the focus-visible polyfill class to do that - - // that for menuItem, because in current version of menuItem that not support focused classes - // TODO: that can be remove after upgrade to V5 - mainClasses.focusVisible - }, - &.Mui-focusVisible { + ${ + // mui focus visible have issue in old version, we use the focus-visible polyfill class to do that + '' + } + &.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItemAvatar/__stories__/__snapshots__/ListItemAvatar.story.tsx.snap b/packages/juno-core/src/components/List/ListItemAvatar/__stories__/__snapshots__/ListItemAvatar.story.tsx.snap index 8d1b39e9..2e00dcf4 100644 --- a/packages/juno-core/src/components/List/ListItemAvatar/__stories__/__snapshots__/ListItemAvatar.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItemAvatar/__stories__/__snapshots__/ListItemAvatar.story.tsx.snap @@ -67,7 +67,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItemAvatar ListItemAvatar color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItemIcon/__stories__/__snapshots__/ListItemIcon.story.tsx.snap b/packages/juno-core/src/components/List/ListItemIcon/__stories__/__snapshots__/ListItemIcon.story.tsx.snap index 70c5a311..6013c125 100644 --- a/packages/juno-core/src/components/List/ListItemIcon/__stories__/__snapshots__/ListItemIcon.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItemIcon/__stories__/__snapshots__/ListItemIcon.story.tsx.snap @@ -34,7 +34,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItemIcon ListItemIcon 1`] color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItemSecondaryAction/__stories__/__snapshots__/ListItemSecondaryAction.story.tsx.snap b/packages/juno-core/src/components/List/ListItemSecondaryAction/__stories__/__snapshots__/ListItemSecondaryAction.story.tsx.snap index 5d43a04a..c37b3590 100644 --- a/packages/juno-core/src/components/List/ListItemSecondaryAction/__stories__/__snapshots__/ListItemSecondaryAction.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItemSecondaryAction/__stories__/__snapshots__/ListItemSecondaryAction.story.tsx.snap @@ -62,7 +62,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItemSecondaryAction ListIt color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListItemText/__stories__/__snapshots__/ListItemText.story.tsx.snap b/packages/juno-core/src/components/List/ListItemText/__stories__/__snapshots__/ListItemText.story.tsx.snap index 071994a6..abd88d30 100644 --- a/packages/juno-core/src/components/List/ListItemText/__stories__/__snapshots__/ListItemText.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListItemText/__stories__/__snapshots__/ListItemText.story.tsx.snap @@ -17,7 +17,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListItemText ListItemText 1`] color: #121212; } -.c0.RcListItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/List/ListSubheader/__stories__/__snapshots__/ListSubheader.story.tsx.snap b/packages/juno-core/src/components/List/ListSubheader/__stories__/__snapshots__/ListSubheader.story.tsx.snap index 328fe3b0..b45de3b8 100644 --- a/packages/juno-core/src/components/List/ListSubheader/__stories__/__snapshots__/ListSubheader.story.tsx.snap +++ b/packages/juno-core/src/components/List/ListSubheader/__stories__/__snapshots__/ListSubheader.story.tsx.snap @@ -17,7 +17,6 @@ exports[`Storyshots 🚀 Cleanup Components/Lists/ListSubheader ListSubheader 1` color: #121212; } -.c1.RcListItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/Menu/__stories__/__snapshots__/Menu.story.tsx.snap b/packages/juno-core/src/components/Menu/Menu/__stories__/__snapshots__/Menu.story.tsx.snap index ba155649..ddd16c0d 100644 --- a/packages/juno-core/src/components/Menu/Menu/__stories__/__snapshots__/Menu.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/Menu/__stories__/__snapshots__/Menu.story.tsx.snap @@ -267,7 +267,6 @@ Array [ color: #121212; } -.c1.RcMenuItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItem.story.tsx.snap b/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItem.story.tsx.snap index e1d306b2..ef385489 100644 --- a/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItem.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItem.story.tsx.snap @@ -56,7 +56,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -207,7 +206,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -363,7 +361,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -520,7 +517,6 @@ Array [ background-color: rgba(102,102,102,0.05); } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -676,7 +672,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -833,7 +828,6 @@ Array [ background-color: rgba(60,153,73,0.05); } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -990,7 +984,6 @@ Array [ background-color: rgba(255,136,0,0.05); } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItemExamples.story.tsx.snap b/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItemExamples.story.tsx.snap index 4e37cc71..b98e2517 100644 --- a/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItemExamples.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/MenuItem/__stories__/__snapshots__/MenuItemExamples.story.tsx.snap @@ -110,7 +110,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -301,7 +300,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -627,7 +625,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -855,7 +852,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -1147,7 +1143,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -1346,7 +1341,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -1545,7 +1539,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -1852,7 +1845,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -2089,7 +2081,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -2380,7 +2371,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -2690,7 +2680,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -2881,7 +2870,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -3206,7 +3194,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -3599,7 +3586,6 @@ Array [ color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } @@ -3873,7 +3859,6 @@ exports[`Storyshots 🚀 Cleanup Components/Menu/MenuItem/MenuItem Examples Seco color: #121212; } -.c0.RcMenuItem-focusVisible, .c0.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuList.story.tsx.snap b/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuList.story.tsx.snap index 3b3883af..db29b398 100644 --- a/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuList.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuList.story.tsx.snap @@ -55,7 +55,6 @@ exports[`Storyshots 🚀 Cleanup Components/Menu/MenuList MenuList 1`] = ` color: #121212; } -.c1.RcMenuItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuListExamples.story.tsx.snap b/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuListExamples.story.tsx.snap index 349ed3ad..6c09d97c 100644 --- a/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuListExamples.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/MenuList/__stories__/__snapshots__/MenuListExamples.story.tsx.snap @@ -93,7 +93,6 @@ Array [ color: #121212; } -.c1.RcMenuItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } @@ -358,7 +357,6 @@ Array [ color: #121212; } -.c1.RcMenuItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/packages/juno-core/src/components/Menu/SubMenu/__stories__/__snapshots__/SubMenu.story.tsx.snap b/packages/juno-core/src/components/Menu/SubMenu/__stories__/__snapshots__/SubMenu.story.tsx.snap index 393940d2..49ace570 100644 --- a/packages/juno-core/src/components/Menu/SubMenu/__stories__/__snapshots__/SubMenu.story.tsx.snap +++ b/packages/juno-core/src/components/Menu/SubMenu/__stories__/__snapshots__/SubMenu.story.tsx.snap @@ -195,7 +195,6 @@ exports[`Storyshots 🚀 Cleanup Components/Menu/SubMenu SubMenu With MenuList 1 color: #121212; } -.c1.RcMenuItem-focusVisible, .c1.Mui-focusVisible { background-color: unset; } diff --git a/sync-github.json b/sync-github.json index 4813821d..b8e780bf 100644 --- a/sync-github.json +++ b/sync-github.json @@ -1,3 +1,3 @@ { - "latestCommitSHA": "092a8881aa49d9a4ccc6d2c6176e96c73c2e303f" + "latestCommitSHA": "b6cce524ea8a73229d46031dea7a404808c5ed57" } \ No newline at end of file