New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit #3 #31

Closed

6 of 8 tasks

jiguantong opened this issue Nov 22, 2024 · 0 comments

Assignees

Collaborator

jiguantong commented Nov 22, 2024 •

edited

Loading

https://github.com/itering/internal-security-audit/pull/137#issuecomment-2489930741
offchain test:
https://github.com/jiguantong/near-multichain/tree/eip712

retryFulfill => retryCallback
retryCallback interface in xapiConsumer
rename rewardAddress to publisherPaymaster, or remove this and just use the msg.sender of publisher?
Sign the structure instead of the transaction, and the transaction can be executed by anyone
- https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/EIP712.sol
- https://github.com/AmazingAng/WTF-Solidity/blob/main/52_EIP712/readme.md

jiguantong self-assigned this

This was referenced Nov 27, 2024

Merged

[Publisher] Adapt to EIP712 ringecosystem/xapi-offchain#40

Open

jiguantong closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment