Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

'total' argument in BaseList.paginate needed? #82

Open
toirl opened this issue Aug 2, 2017 · 0 comments
Open

'total' argument in BaseList.paginate needed? #82

toirl opened this issue Aug 2, 2017 · 0 comments
Labels

Comments

@toirl
Copy link
Member

toirl commented Aug 2, 2017

The paginate method of the BaseList has since recent versions a new 'total' argument. I am currently not sure why this needs to be provided to the method as the total size if the list can be obtained from the list itself. This change breaks the API in other applications as the call of paginate now requires an extra argument.

7fbf08a sets a default value for total and set the value to the len of self.items. This seems to be OK in most cases.

TODO:
Check if there is any usecase where providing total as extra argument makes sense.

@toirl toirl added the question label Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant