Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit of 20 results in Nearby Venue Search #293

Open
Pohli opened this issue Aug 4, 2019 · 5 comments
Open

Remove limit of 20 results in Nearby Venue Search #293

Pohli opened this issue Aug 4, 2019 · 5 comments

Comments

@Pohli
Copy link

Pohli commented Aug 4, 2019

Example: If I search for Gas Stations nearby Dortmund I always get 20 results whatever Radius I've selected (I tried 5, 10 and 20 km).

@rinigus
Copy link
Owner

rinigus commented Aug 5, 2019

Yes, but these stations should be sorted according to the distance from point that you search from. So, what would be a reasonable limit in your opinion?

@Pohli
Copy link
Author

Pohli commented Aug 5, 2019

I suggest to keep the limit of 20 results for the initial search but add an Show/Load More option in a bottom pulley menu on the result page. Btw.: Maybe 20 results would be enough if I could search for a specific gas station brand but that's another topic. Related to #261

@rinigus
Copy link
Owner

rinigus commented Aug 5, 2019

Nearby search also has "Name" option. Maybe use that. For providers that don't have separate Name, you could just use Type as a Name

@Pohli
Copy link
Author

Pohli commented Aug 5, 2019

I checked it:

  1. Default search provider Foursqare (I use this usually): no Name field, typed brand name "Esso" into Type field: no results.
  2. Search provider MapQuest Nominatim: no Name field, typed brand name into Type field: 6 valid results.
  3. Search provider OSM Scout (has Name field): selected "Gas Station", "Gas Stations" and "Any" for Type field, typed brand name into Name field: always the same 4 valid results.

Selected 10 km Radius for all cases.
I don't like to use Search provider OSM Scout so much cause the search takes much longer than the others on my Jolla Phone.

Anyway if one wants to search for any gas stations the 20 results limit would still occur. What do you think about the above mentioned Load More option?

@rinigus
Copy link
Owner

rinigus commented Aug 5, 2019

"Load more" is somewhat harder to implement - its a new call. Not impossible though.

I may look into how to specify name for Foursquare - its probably a better solution in longer term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants