Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other currency/issuer formats for search #624

Closed
ckniffen opened this issue Mar 13, 2023 · 2 comments
Closed

Support other currency/issuer formats for search #624

ckniffen opened this issue Mar 13, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented Mar 13, 2023 •
edited
Loading

The search currently supports {currencyCode}.{issuer} we should also support {currencyCode}:{issuer}, {currencyCode}+{issuer}, and {currencyCode}-{issuer}.

These are formats used by some many dexs.

https://gatehub.net/markets/XRP/EUR+rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq
https://xdex.com/tokens/SOLO:rsoLo2S1kiGeCcn6hCUXVrCpGMWLrRrLZz
https://sologenic.org/trade?network=mainnet&market=534F4C4F00000000000000000000000000000000%2BrsoLo2S1kiGeCcn6hCUXVrCpGMWLrRrLZz%2FXRP
https://xpmarket.com/dex/XRP/USD-rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B
@ckniffen ckniffen added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2023
@intelliot
Copy link
Collaborator

For reference, could we link (here in this issue) examples of explorers and dexs that use the aforementioned formats?

@ckniffen ckniffen changed the title Support other currency/issuer formats Support other currency/issuer formats for search May 18, 2023
@jonathanlei jonathanlei mentioned this issue Jun 27, 2023
Merged
@ckniffen
Copy link
Collaborator Author

ckniffen commented Jul 3, 2023

fixed by #762

@ckniffen ckniffen closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@intelliot @ckniffen