Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priv 1.12 ACT - CSR Coverage #13

Open
2 of 13 tasks
jjscheel opened this issue Mar 16, 2023 · 28 comments
Open
2 of 13 tasks

Priv 1.12 ACT - CSR Coverage #13

jjscheel opened this issue Mar 16, 2023 · 28 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 16, 2023

Technical Group

Privileged Spec IC

ratification-pkg

Priv 1.12

Technical Liaison

Danish Hussain

Task Category

Arch Tests

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • ACT SIG sign-off date (if ACT work):

Waiver

  • Freeze
  • Ratification

Pull Request Details

  • SV39 coverpoints are complete, its coverage report and coverpoints are available here: Coverage PR, Test PR - Closed, to be generated with tool updates
  • SV48 coverpoints are complete, its coverage report and coverpoints are available here: Coverage PR, Test PR - Closed, to be generated with tool updates
  • Privileged Architecture coverage: Coverage PR - Merged
@jjscheel jjscheel self-assigned this Mar 16, 2023
@jjscheel jjscheel changed the title Priv 1.12 ACT CSR Coverage Priv 1.12 ACT - CSR Coverage Apr 6, 2023
@jjscheel
Copy link
Contributor Author

@UmerShahidengr, when you have a moment, can you provide an update here:

  • Who will be working on this item?
  • When do we envision them starting?
  • If they've already started, what is the current status?

Thanks!

@UmerShahidengr
Copy link

Update Apr 25th, 2023 => Previously, Danish Hussain was working on this issue, he developed WARL coverpoints and submitted a PR here. Now he has switched to some other task, thus this task has been assigned to Ali Tariq now. He will be on-boarded this week.

Task for next week => On-boarding Ali Tariq

@UmerShahidengr
Copy link

Update May 7th, 2023 => PMP Functional coverpoint definition has been started. Things are moving in right direction. Coverpoint structure will soon be discussed with Pawan and Allen once it will be reviewed internally.
Next week goal => Update the exisitng PR with functional coverpoints of PMP.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 8, 2023

Thanks. Sounds like progress. Will move to next week's Agenda.

@UmerShahidengr
Copy link

Update May 23rd, 2023 => Not much update on this task yet.

@jjscheel
Copy link
Contributor Author

Ok, thanks, @UmerShahidengr. Removing from this week's agenda. Touch base again in 2 weeks.

One question: did we get coverpoints reviewed with Pawan and Allen?

@UmerShahidengr
Copy link

Update ⇾ June 12th, 2023:
CSR cover points are in progress, we are expecting a PR in the next week.

@jjscheel
Copy link
Contributor Author

Ok. We will re-visit in 3 weeks.

@UmerShahidengr UmerShahidengr mentioned this issue Jul 11, 2023
13 tasks
@UmerShahidengr
Copy link

Update ⇾ July 11th, 2023
PMP coverpoints and coverage testing is in progress. Updates are getting tracked internally, PR will be released after the internal review.

@UmerShahidengr
Copy link

Update ⇾ Aug 15th, 2023:
PMP coverpoints have been submitted for review.

@UmerShahidengr
Copy link

Update ⇾ September 12th, 2023
No update on this.

@jjscheel
Copy link
Contributor Author

@allenjbaum, can you provide guidance on an outlook for coverage plan review? Thanks!

@UmerShahidengr
Copy link

Update ⇾ September 26th, 2023
PMP coverpoints are in internal review stage, it will be available for the PR before our next meeting.

@UmerShahidengr
Copy link

Update ⇾ October 10th, 2023:
This is the only active SoW on which 10xEngineers team is working on. This work is stalling PMP, ePMP, and VM PRs. We will deliver all coverpoints in this quarter, initially we have been working on PMP and VM coverpoints which will be released soon.

@UmerShahidengr
Copy link

Update ⇾ October 24th, 2023
PMP and VM coverpoints are in progress

@UmerShahidengr
Copy link

Update Nov 3rd, 2023:

@jjscheel
Copy link
Contributor Author

jjscheel commented Nov 3, 2023

Thanks, @UmerShahidengr. I've updated the PR section of the description above!

@UmerShahidengr
Copy link

Update ⇾ November 28th, 2023

  • PMP coverpoints have been added, PR at CTG
  • To address the coverpoint definitions for VM and PMP, modifications have been implemented in the RISCV-ISAC tool. The corresponding pull request, detailing numerous changes as outlined in its description, can be found at the following link. These modifications are set to undergo initial review during the upcoming sig-arch meeting.

@UmerShahidengr
Copy link

Update ⇾ December 12th, 2023
The review process is going on smoothly.

@UmerShahidengr
Copy link

Update ⇾ January 30th, 2024
In review process

@jjscheel
Copy link
Contributor Author

jjscheel commented Feb 1, 2024

"Review" is only pre PR work. Returning to "Developing" State.

@UmerShahidengr
Copy link

Update ⇾ March 5th, 2024
The coverage support for priv arch is in progress and getting tracked in this PR.

@jjscheel
Copy link
Contributor Author

jjscheel commented Mar 5, 2024

Thanks, @UmerShahidengr. PR list updated in first entry.

@UmerShahidengr
Copy link

Update ⇾ April 2nd, 2024
PR related to Priv arch support in ISAC is yet to be merged. It is complete from our end. riscv-software-src/riscv-isac#80.
next task will be to start the ACTs of all CSRs.

@UmerShahidengr
Copy link

Update ⇾ April 18th, 2024
@MuhammadHammad001 has submitted PR in RISCOF to add coverage support related to Priv Arch. He has also submitted a translator for improving the coverpoint definitions related to the Priv Arch.
@allenjbaum and @MuhammadHammad001 have been working on the translator tool.

@UmerShahidengr
Copy link

Update April 30th, 2024:
Work in progress. Translator work and VM coverpoints are under way

@UmerShahidengr
Copy link

Update June 11th, 2024:
The progress of this SoW has been getting tracked in different other issues (PMP ACTs, VM ACTs), we will wrap up PMP and VM coverpoints first, then we will start the other section of Priv Architecture.

@jjscheel
Copy link
Contributor Author

@UmerShahidengr, do you have an update here on the SV39 and SV48 coverpoints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: As-planned
Development

No branches or pull requests

3 participants