Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector SAIL #24

Closed
2 of 13 tasks
jjscheel opened this issue Mar 17, 2023 · 18 comments
Closed
2 of 13 tasks

Vector SAIL #24

jjscheel opened this issue Mar 17, 2023 · 18 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 17, 2023

Technical Group

Vector TG

ratification-pkg

Vector

Technical Liaison

Krste

Task Category

SAIL model

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs:

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • SAIL Golden Model sign-off date:

Waiver

  • Freeze
  • Ratification

Pull Request Details

Original, massive PR was too large for community consumption: riscv/sail-riscv#149

Revised plan was to submit, smaller PRs. Expect 5-8 PRS instead to split original code. Here's the current list:

@jjscheel
Copy link
Contributor Author

Hello, @XinlaiWan! No action needed here. I'm just tracking your work for DevPartners. Please keep working with the SAIL community. You're doing great work. Thank you!!!

@XinlaiWan
Copy link

Got it. Thank you, Jeff!

@jjscheel
Copy link
Contributor Author

Email from Xi:

RVV Sail Model is waiting for folks reviewing the floating point instructions. We have one more PR and then Sail will be all set.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 2, 2023

@billmcspadden-riscv reported that @XinlaiWan is submitting his 5th and final PR for this item.

Given this, I'm setting the Projected Completion to May 23.

@XinlaiWan, we also discussed the possibility of having your start work on Zvfh and Zvfhmin which was recently ratified. I'm working the SOW now and hope to have it ready by next meeting. Please chat with Xi about this.

@jrtc27
Copy link

jrtc27 commented May 2, 2023

When is all the code going through its final review to fix any code style issues that weren't caught because it was going to vector-dev not main and others did not want to impose the same strict standards for that branch?

@jjscheel
Copy link
Contributor Author

jjscheel commented May 8, 2023

Updated primary information with reference to 5th PR.

@jjscheel
Copy link
Contributor Author

@billmcspadden-riscv confirmed in today's meeting that all code in the vector branch will be undergoing another PR for general code cleanup. All feature/function code has been included with the 5th PR.

@jjscheel
Copy link
Contributor Author

Added reference to PR for merge of all code into main.

@jjscheel
Copy link
Contributor Author

@XinlaiWan, any updates here?

@XinlaiWan
Copy link

The final PR of merging all code into the main branch is being reviewed, and we're waiting for reviewer's suggestions or approvals.

@jjscheel
Copy link
Contributor Author

jjscheel commented Sep 13, 2023 via email

@jjscheel
Copy link
Contributor Author

Hello, @XinlaiWan! As your work winds down with this item. Can you look at #28 (Zvfh/Zvfhmin) SAIL work next? I'm going to assign it to you to begin discussions. Thanks!

@XinlaiWan
Copy link

Hi Jeff, we'll follow the progress of this, and the development tasks will be assigned to my RIOS colleagues.

@jjscheel
Copy link
Contributor Author

The final PR Accepted. @billmcspadden-riscv, can you confirm this SOW has been met, please?

@jrtc27
Copy link

jrtc27 commented Nov 27, 2023

Not complete. riscv/sail-riscv#359 exists, and it likely needs testing to find whatever other issues may remain, since testing can't have been all that thorough if that snuck through (assuming it was more than just a subtle encoding issue, as appears to be the case).

@jjscheel
Copy link
Contributor Author

Understand @jrtc27. Thanks for the update. It's not surprising that in 10+ KLOC there's a bug or two. I'll keep this open until this first batch of active issues get closed.

However, the goal for my tracking is to get the function merged into a community for broader exposure and support, not to ensure the last bug has been removed. Yes, we don't want to compromise code quality, but on the other hand waiting for error-free code is impractical.

@jjscheel jjscheel moved this from At-risk to Blocked in RISC-V DevPartner Work Mar 5, 2024
@jjscheel
Copy link
Contributor Author

@billmcspadden-riscv, any update on the status of riscv/sail-riscv#359?

@jjscheel
Copy link
Contributor Author

Final issue closed. Complete.

@jjscheel jjscheel moved this from Blocked to As-planned in RISC-V DevPartner Work Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: As-planned
Development

No branches or pull requests

4 participants