Rework the extension test macros section #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a list of macros, that should be extended for each new extension. Let's rephrase the section such, that the wording targets all extensions that are supported by compilers and remove the incomplete list. Signed-off-by: Christoph Müllner <[email protected]>
cmuellner
force-pushed
the
ext-test-macro
branch
from
0ec6d0f to
ede18b7
Compare
|
Rebased. @kito-cheng: ping |
asb
approved these changes
Jan 29, 2024
kito-cheng
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM, apparently I missed this PR somehow, anyway thanks for improving this section, I just got asked around XXX extension has marco to check or not, and every time I point I point to here, I also need spend time to explain the table isn't up to date too, so I think just dropping whole table can make people less confusion (on why XXX extension is not list their) at first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to rework the extension test macros section and drop the useless (and incomplete) extension test macro list.
Previous attempts to clean up this section can be found in #27 and #28.
This should avoid the need for PRs like #55 that add something obvious done by GCC and LLVM without the need for this list. Further, we recently also discussed this in the context of #44 (adding bitmap and scalar crypto extensions to the list). So I think it is time to remove the list.