Clarify SBI IPI and RFENCE error codes #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
|
I agree with this. SBI_ERR_INVALID_PARAM can also be specified to apply to asids and vmids for the rfence functions, which the binary encoding section doesn't consider. Also, adding SBI_ERR_FAILED "The reset request failed for unspecified or unknown other reasons." gives SBI implementations a catchall if they have cases not considered by the spec. I recommend we add that as well. |
|
Please update the changelog for 3.0-rc1 as part of this PR |
Add SBI_ERR_INVALID_PARAM as a possible error code to IPI and RFENCE functions which take in `hart_mask` and `hart_mask_base` input parameters. While this is specified in the Binary Encoding chapter, explicitly including it in the function descriptions would make it harder to miss. SBI_ERR_INVALID_PARAM is also specified for invalid `asid` and `vmid` parameters in some RFENCE functions. Furthermore, also add SBI_ERR_FAILED as the default error code for any other unspecified or unknown failure reasons. Signed-off-by: James Raphael Tiovalen <[email protected]>
jamestiotio
force-pushed
the
hart-list-params
branch
from
4d59365 to
500ab3f
Compare
jamestiotio
changed the title
|
I have incorporated @jones-drew's suggestions and updated the changelog as requested by @avpatel in the latest commit. |
Signed-off-by: Atish Patra <[email protected]>
|
Resolved the conflict with change log and did a manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SBI_ERR_INVALID_PARAM as a possible error code to IPI and RFENCE functions which take in
hart_maskandhart_mask_baseinput parameters. While this is specified in the Binary Encoding chapter, explicitly including it in the function descriptions would make it harder to miss. SBI_ERR_INVALID_PARAM is also specified for invalidasidandvmidparameters in some RFENCE functions.Furthermore, also add SBI_ERR_FAILED as the default error code for any other unspecified or unknown failure reasons.
CC: @atishp04 @jones-drew