Minor simplification of Python boolean #305
Conversation
| include_pseudo = False | ||
| if "-pseudo" in sys.argv[1:]: | ||
| include_pseudo = True | ||
| include_pseudo = "-pseudo" in sys.argv[1:] |
There was a problem hiding this comment.
I agree to the concise approach being followed here to reduce the number of lines of codes. Given that we should focus on optimizing the codes as much as possible, but at the same time, we should not forget its maintainability and readabaility.
Following, "Explicit is better than Implicit": the core tenet of Python, the already existing codes explicitly communicates the default state for the inclusion of pseudo instructions as (False) and only sets it to True conditionally, making the flow of logic clearer. Readers can follow the intent more easily than inferring the meaning from a single line assignment.
Additionally, I am tagging the discussions for reference regarding pseudo instructions inclusion for more information as to why we are using flags for explicit behaviour : #286 and #289
There was a problem hiding this comment.
I can't say I agree here. This isn't more explicit; it's just more verbose.
This is standard best practice. See this blog for example.
In the long term it would be much better to use argparse of course, but this is a pretty straightforward simplification.
There was a problem hiding this comment.
I agree with @Timmmm on this one. Since it isn't an esoteric construction, the conciseness improves readability.
No description provided.