-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused imports #306
Conversation
I don't have a strong opinion on the matter, so I'll let the two of you hash this out, and will follow whatever is ultimately decided. |
Remove unused Python import statements.
097e67a
to
938e6d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
===========================================
- Coverage 95.87% 42.63% -53.24%
===========================================
Files 10 10
Lines 752 720 -32
===========================================
- Hits 721 307 -414
- Misses 31 413 +382 ☔ View full report in Codecov by Sentry. |
@IIITM-Jay do you have any outstanding objections to this? As I understand it your comment was related to the |
@Timmmm No, I don't have any objections regarding the PR. Just a small thing, if possible, otherwise I could also take that up in a separate PR if you wish - could you please remove the wildcard imports and import only the necessary and sufficient methods of As for a single work we should not include two statements one with commented out and other as wildcard. Let me know whatever suits you! |
@Timmmm and @aswaterman I have removed the unwanted commented line form the files included in this PR, for importing methods from |
Signed-off-by: Jay Dev Jha <[email protected]>
4495699
to
14d6674
Compare
Sounds good to me. I squashed your commits for a slightly neater history. Let's resolve the wildcard imports in another PR like you say. (I can do it if you like; VSCode makes it very easy.) |
Remove unused Python import statements.