Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtract overflow in ascii mode #4

Open
skyzh opened this issue Feb 19, 2023 · 1 comment
Open

subtract overflow in ascii mode #4

skyzh opened this issue Feb 19, 2023 · 1 comment

Comments

@skyzh
Copy link
Member

skyzh commented Feb 19, 2023

thread 'tokio-runtime-worker' panicked at 'attempt to subtract with overflow', /Users/skyzh/.cargo/registry/src/github.com-1ecc6299db9ec823/pretty-xmlish-0.1.7/src/lib.rs:253

if this line is changed to .ascii

https://github.com/risinglightdb/risinglight/blob/2143a7c93d262eb7334298e357a358b0f675bff6/src/executor_v2/explain.rs#L28

and run make apply_planner_test on macOS

@ice1000
Copy link
Collaborator

ice1000 commented Feb 19, 2023

The ascii mode is not well implemented as the Unicode version is the intended mode of this thing. Plus I still don't understand how are things different across platforms.. I don't think I assumed anything platform dependent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants