Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: run_script and run_file are different #116

Open
xxchan opened this issue Dec 8, 2022 · 1 comment
Open

runner: run_script and run_file are different #116

xxchan opened this issue Dec 8, 2022 · 1 comment
Labels
A-include related to the behavior of include bug Something isn't working

Comments

@xxchan
Copy link
Member

xxchan commented Dec 8, 2022

.. which can be confusing

Current behavior is: run_file will handle include while run_script won't.
@xxchan
Copy link
Member Author

xxchan commented Dec 8, 2022 •
edited
Loading

Well the reason is: when we introduced include (#8), the record variant and run_file are intentionally marked as #[doc(hidden)] (we should have added sth like run_script_with_include instead of run_file at that time...); then during refactor, we didn't consider this factor and removed #[doc(hidden)] (#11), so the problem occurs... 😇

@xxchan xxchan added bug Something isn't working A-include related to the behavior of include labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-include related to the behavior of include bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xxchan