Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Vec<Vec<String>> for external engine #138

Merged
merged 3 commits into from
Dec 30, 2022
Merged

fix: use Vec<Vec<String>> for external engine #138

merged 3 commits into from
Dec 30, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 30, 2022

@xxchan xxchan force-pushed the revert-137-wrj/trim-before-sort branch from 68d01d8 to a4bc70b Compare December 30, 2022 14:54
@xxchan
fix doctest
3ab2153 
Signed-off-by: xxchan <[email protected]>
wangrunji0408
wangrunji0408 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soga.

@wangrunji0408 wangrunji0408 merged commit 6b2f981 into main Dec 30, 2022
@wangrunji0408 wangrunji0408 deleted the revert-137-wrj/trim-before-sort branch December 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

@TennyZhuang TennyZhuang TennyZhuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @TennyZhuang @wangrunji0408