-
Notifications
You must be signed in to change notification settings - Fork 696
Open
Milestone
Description
Description:
We recently enabled the clippy lints #![warn(clippy::large_futures, clippy::large_stack_frames)]
in risingwave_connector. This revealed warnings in both the Pulsar and Kafka source enumerator implementations.
A temporary workaround (Box::pin in the root async method) was applied in RisingWave, but the underlying issue likely comes from these upstream crates.
Next Steps:
- Open issues in the pulsar and kafka repos to raise awareness.
- Contribute PRs upstream to fix the struct allocations.
- After their patched versions are released, bump the dependencies in RisingWave.
- Remove the temporary Box::pin workaround once upstream fixes are in place.
Metadata
Metadata
Assignees
Labels
No labels