From 1e6ee727085f9193f4dd2325162e02b5555692af Mon Sep 17 00:00:00 2001
From: efreja <efreja@wanadoo.fr>
Date: Wed, 28 Apr 2021 15:17:20 +0200
Subject: [PATCH] onaudioprocess continuously called (on FireFox)

Noticed this while working on https://github.com/rism-digital/midi-player/issues/23, that onAudioProcess was continuously called (on FireFox) even after playback completion.
This fix solves the issue.
---
 player/midiplayer.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/player/midiplayer.js b/player/midiplayer.js
index e789cc3..776cde7 100644
--- a/player/midiplayer.js
+++ b/player/midiplayer.js
@@ -70,7 +70,6 @@ var emptyBuffer;
 function initAudio() {
     audioCtx = new (window.AudioContext || window.webkitAudioContext)({sampleRate:SAMPLE_RATE});
     scriptNode = audioCtx.createScriptProcessor(BUFFER, 0, channels);
-    scriptNode.onaudioprocess = onAudioProcess;
     
     source = audioCtx.createBufferSource();
     circularBuffer = new CircularAudioBuffer(8);
@@ -81,7 +80,8 @@ function initAudio() {
     console.debug("initAudio");
 }
 
-function startAudio() {    
+function startAudio() {
+    scriptNode.onaudioprocess = onAudioProcess;
     scriptNode.connect(audioCtx.destination);
     console.debug("startAudio");
 }
@@ -89,7 +89,7 @@ function startAudio() {
 function pauseAudio() {
     circularBuffer.reset();
     scriptNode.disconnect();
-	console.debug("pauseAudio");
+    console.debug("pauseAudio");
 }
 
 
@@ -285,6 +285,7 @@ function stop() {
     _EM_seekSamples = 0;
     circularBuffer.reset();
     pauseAudio();
+    scriptNode.onaudioprocess = null;
 	
     midiPlayer_totalSamples = 0;
     midiPlayer_currentSamples = ULONG_MAX;