Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull all routes into a separate router #54

Closed
mmmaaatttttt opened this issue Apr 30, 2021 · 0 comments
Closed

Pull all routes into a separate router #54

mmmaaatttttt opened this issue Apr 30, 2021 · 0 comments
Assignees
Labels
backend good first issue refactor Refactor of existing functionality

Comments

@mmmaaatttttt
Copy link
Collaborator

Problem description:

Related to #46 but should probably happen first. The app uses a weird pattern to attach the routes to the express app. See https://github.com/rithmschool/numbers_api/blob/master/app.js#L124 and https://github.com/rithmschool/numbers_api/blob/master/routes/api.js#L99.

Suggested solution:

Refactor to use express.Router. This will also be beneficial so that we can silo all of these routes and create a separate router for a v2 of the API.

@mmmaaatttttt mmmaaatttttt added good first issue refactor Refactor of existing functionality backend labels Apr 30, 2021
Nalipp added a commit that referenced this issue May 5, 2021
@Nalipp Nalipp closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend good first issue refactor Refactor of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants