Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should be the best practices for source ids? #5

Open
olivierdupuis opened this issue Jul 8, 2020 · 0 comments
Open

What should be the best practices for source ids? #5

olivierdupuis opened this issue Jul 8, 2020 · 0 comments
Labels
question Further information is requested

Comments

@olivierdupuis
Copy link

olivierdupuis commented Jul 8, 2020

This is more of a question to explore than an actual issue.

Working with the framework on a project, the ids which are integers at the source, were appended a prefix which transformed them to varchars. The only "issue" is when you're debugging and want to get to the source's id, it's quicker to copy the whole value instead of removing the prefix. Also, I think it might be better practice to stick to the source's natural field type instead of forcing it to varchars.

My preference for this project has been

  • to not use prefixes
  • name the field as source_table_natural_key
  • keep source's natural field type.

Example:

select
  id as platform_transaction_natural_key

┆Issue is synchronized with this Jira Task by Unito

@olivierdupuis olivierdupuis added the question Further information is requested label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant