Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI build Travis #52

Open
ritwik12 opened this issue Jan 8, 2020 · 12 comments
Open

Setup CI build Travis #52

ritwik12 opened this issue Jan 8, 2020 · 12 comments
Assignees
@Satyabrat35
Labels
good first issue Good for newcomers

Comments

@ritwik12
Copy link
Owner

ritwik12 commented Jan 8, 2020

It will be good to have travis here
@ritwik12 ritwik12 added the good first issue Good for newcomers label Jan 8, 2020
@Satyabrat35
Copy link
Contributor

Would like to work on it.

@ritwik12
Copy link
Owner Author

Sure, please send PR @Satyabrat35

@ritwik12
Copy link
Owner Author

ritwik12 commented Feb 4, 2020

@Satyabrat35 Any progress here?

@Satyabrat35
Copy link
Contributor

I am figuring out the tests for the build. Will write the tests and make a PR in a week.

@Satyabrat35
Copy link
Contributor

Review #55

@ritwik12
Copy link
Owner Author

ritwik12 commented Feb 6, 2020

@Satyabrat35 That is good but it is a basic Travis integration. We need new travis for new PR's code to make sure they will work well once we merge it. For now your tests are only for the already present code in this Repo.

@ritwik12
Copy link
Owner Author

ritwik12 commented Feb 6, 2020

Let me know if you want to contribute further to this :)

@ritwik12
Copy link
Owner Author

ritwik12 commented Feb 6, 2020

@Satyabrat35 Please check #57 where it fails. Also, can we add flake8 or something else also to make sure the Code is python only. For eg: I just wrote "Test Travis" in that PR. So as per Python code, it should give error as it's not a variable nor a comment.

@Satyabrat35
Copy link
Contributor

Yeah sure .. will look into #57

@Satyabrat35
Copy link
Contributor

Satyabrat35 commented Feb 6, 2020 •
edited
Loading

Review #58 and #57

@sudhanshu-chauhan
Copy link
Contributor

@ritwik12 I would like to take this up and work towards it.

@ritwik12
Copy link
Owner Author

@sudhanshu-chauhan Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Satyabrat35 Satyabrat35

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sudhanshu-chauhan @ritwik12 @Satyabrat35