Skip to content

Commit

Permalink
Call updateLayoutBounds on NestedArtboardLayout
Browse files Browse the repository at this point in the history
I think this is the right fix here. Since the calls to updateLayoutBounds are now passed down through layout children rather than on advance, we also needed to call updateLayoutBounds on NestedArtboardLayout, since those "provide" their layout nodes to their parent artboards layout tree (thus updateLayoutBounds doesn't get called during their own Artboard's advance).

Diffs=
6931974fe3 Call updateLayoutBounds on NestedArtboardLayout (#8398)
c7cd1c8c74 editor: support vector n-slicing in runtime (#8395)
b3534f1f8f Nnnn text alignment and fit (#8385)
52963ca423 hierarchical updates to layout (#8386)
96d45f6824 Do not load files with invalid paint mutators. (#8366)
76f79a22e2 testing animation smoothing (#8363)
86f2d78a90 NestedArtboardLayout marks its parent artboard layoutNodeDirty (#8383)
2516daf1e0 Nnnn system data enums (#8380)
54629ea542 LayoutComponent clip defaults to false. (#8368)
0c8fa5c313 Add AdvancingComponent & animate flag to advance() (#8362)

Co-authored-by: Philip Chung <[email protected]>
  • Loading branch information
philter and philter committed Oct 23, 2024
1 parent 9abe92b commit d62035e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
80da365913302db2a303def22846d02b35a4eab8
6931974fe3eb4a5dcda546cafe2ed50e9da2c939
1 change: 1 addition & 0 deletions lib/src/rive_core/nested_artboard.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ abstract class MountedArtboard {
void artboardHeightOverride(double height, int heightUnitValue, bool isRow);
void artboardWidthIntrinsicallySizeOverride(bool intrinsic);
void artboardHeightIntrinsicallySizeOverride(bool intrinsic);
void updateLayoutBounds(bool animate);
void dispose();
void setDataContextFromInstance(ViewModelInstance viewModelInstance,
DataContext? dataContextValue, bool isRoot);
Expand Down
3 changes: 3 additions & 0 deletions lib/src/runtime_mounted_artboard.dart
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ class RuntimeMountedArtboard extends MountedArtboard {
@override
void artboardHeightIntrinsicallySizeOverride(bool intrinsic) {}

@override
void updateLayoutBounds(bool animate) {}

@override
double get originalArtboardWidth => originalArtboardInstanceSize.width;

Expand Down

0 comments on commit d62035e

Please sign in to comment.