t/real-export-setup.t - fix broken test in SETUPALT #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test calls Test::SubExport::SETUPALT->import(":all") but there is
not such method defined, and only works because Perl special cases the
handling of a missing import() method to not throw an exception, thus
making such calls a no-op. This no-op behavior simulates what would
happen if there was a UNIVERSAL::import() method that does nothing.
In 5.39.0 Perl added a UNIVERSAL::import() method which throws an error
if it is passed an argument, as the argument will be ignored, and this
pattern is usually indicitive of a usage error, especially on case
insensitive file systems. This then breaks this test.
This patch could also simply remove the call to import() but that would
make the code look a bit odd. Instead we use the import function
provided by Exporter, and define an "all" tag with no symbols in it.
|
I have finally made the time to look into this. I think I'll apply this patch, along with a big comment. Thanks! |
|
@demerphq Oh and by the way, thanks for a nice clear commit message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test calls Test::SubExport::SETUPALT->import(":all") but there is not such method defined, and only works because Perl special cases the handling of a missing import() method to not throw an exception, thus making such calls a no-op. This no-op behavior simulates what would happen if there was a UNIVERSAL::import() method that does nothing.
In 5.39.0 Perl added a UNIVERSAL::import() method which throws an error if it is passed an argument, as the argument will be ignored, and this pattern is usually indicitive of a usage error, especially on case insensitive file systems. This then breaks this test.
This patch could also simply remove the call to import() but that would make the code look a bit odd. Instead we use the import function provided by Exporter, and define an "all" tag with no symbols in it.
See: Perl/perl5#21269
Happy Birthday.