Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all requests cancellable #14

Open
Arech opened this issue Jun 17, 2011 · 3 comments
Open

Make all requests cancellable #14

Arech opened this issue Jun 17, 2011 · 3 comments

Comments

@Arech
Copy link

Arech commented Jun 17, 2011

Hi!

It would be very nice, if the library will provide some means to cancel requests. Exponential back-off algo is really cool, but sometime it is absolutely necessary to be able to cancel too long running request.

@rjrodger
Copy link
Owner

That is an excellent idea! I'll need to think about a good API for that - a callback that returns true to stop the request?

@Arech
Copy link
Author

Arech commented Jun 22, 2011

I'm not sure if a callback will be good... I think it is better to use traditional handles, like a work with timeouts:

var h=setTimeout(..);
...
clearTimeout(h);

@Arech Arech closed this as completed Jun 22, 2011
@Arech Arech reopened this Jun 22, 2011
@rjrodger
Copy link
Owner

Arech adding you as a contrib, see https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants