Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang 26 test case does not fail for all system locales #488

Open
AndrewC19 opened this issue Oct 11, 2022 · 1 comment
Open

Lang 26 test case does not fail for all system locales #488

AndrewC19 opened this issue Oct 11, 2022 · 1 comment

Comments

@AndrewC19
Copy link

The test for bug Lang-26 (testLang645) only fails for particular system locales. For example, if your system locale is en_US, the test will fail. However, if your system locale is en_GB, the test will pass.

The test can be modified to ensure that it always catches the bug, regardless of your own system locale by adding the line Locale.setDefault(new Locale("en", "US")); to the start of the test.

@rjust
Copy link
Owner

rjust commented Sep 21, 2024

@markro49 @mernst Looks like this change would be in line with other changes we made to ensure reproducibility for Java 11.

If this change allows us to remove the requirement to set TZ for external use of D4J artifacts, I think we should go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants