Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor map.html to use as little templating logic in the JS part as possible #7

Open
4lm opened this issue Feb 14, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@4lm
Copy link
Contributor

4lm commented Feb 14, 2019

This commit replaced some JavaScript (JS) logic with the Django templating logic from a previous code state. It was a quick, working solution, which didn't change the end result, but recoupled the Django templating logic with the JS code: b7f6c9d

As @nesnoj noted should we refactor map.html to use as little templating logic in the JS part as possible and take the already done work in this area as an guide.

Should be done in a few others, which we don't have time to spend right now.

@4lm 4lm added the enhancement New feature or request label Feb 14, 2019
@nesnoj nesnoj added this to the nice_to_have milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants