Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization keeps running when page is left or reloaded #348

Closed
nesnoj opened this issue Aug 31, 2023 · 3 comments
Closed

Optimization keeps running when page is left or reloaded #348

nesnoj opened this issue Aug 31, 2023 · 3 comments
Assignees
Labels
bug 🐞 Something isn't working

Comments

@nesnoj
Copy link
Member

nesnoj commented Aug 31, 2023

To free the CPU thread the optimization should be cancelled.
Maybe use JS' beforeunload to notify the backend?

@nesnoj nesnoj added the bug 🐞 Something isn't working label Aug 31, 2023
@nesnoj
Copy link
Member Author

nesnoj commented Sep 28, 2023

Another question on this @henhuy: If an optimization is running and I go back to settings, change a param and again forward to results, is a second one started for that very same user? So quickly repeating this 10 times will start 10 processes?

@henhuy
Copy link
Collaborator

henhuy commented Sep 28, 2023

Unfortunately, yes. And it's even worse, that after two simulations with same parameters are stored, loading a simulation with given parameters leads to an internal error, as Django expects a single result from query instead of multiple rows... :(

@nesnoj
Copy link
Member Author

nesnoj commented Oct 9, 2023

Fixed in #377

@nesnoj nesnoj closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants