Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app more accessible #66

Open
bmlancien opened this issue Oct 4, 2022 · 3 comments
Open

Make app more accessible #66

bmlancien opened this issue Oct 4, 2022 · 3 comments
Assignees
Labels
enhancement 🚀 New feature or request wontfix 💔 This will not be worked on

Comments

@bmlancien
Copy link
Contributor

Right now the app has a 100% score on the Lighthouse accessibility tool in the browser, but there are still a few things that could/should be improved:

  • Being able to navigate through all items with the tab key (right now the tabs map/charts are not accessible)
  • Check if using the web accessibility features from echarts makes sense and if yes, implement them
  • Optional: Think of a way to display map results/data to visually impaired users, e.g. display the results as a list that a user can go through with a screen reader (not sure if and how it is possible)

I also opened that issue to emphasise the importance of accessibility, especially because the RLI wants to be all inclusive. Web accessibility is quite a broad topic, so we won't be able to manage everything, but I think it is good to always have this on the back of our minds.

@bmlancien bmlancien added the enhancement 🚀 New feature or request label Oct 4, 2022
@bmlancien bmlancien self-assigned this Oct 4, 2022
@bmlancien
Copy link
Contributor Author

Optional: Think of a way to display map results/data to visually impaired users, e.g. display the results as a list that a user can go through with a screen reader (not sure if and how it is possible)

Something better and easier to build would be using tab key to navigate inside the map: Once the map is selected, a municipality popup shows up and from there the user can navigate to other municipalities popups.

@4lm
Copy link
Contributor

4lm commented Oct 6, 2022

Right now the app has a 100% score on the Lighthouse accessibility

@nesnoj and @henhuy, just not to give the wrong impression that our app is accessible and that @bmlancien's suggestions are optional or just improvements. A Lighthouse score of 100 % is easily reached by adding the necessary alt and aria attributes. These are standard today and part of the Bootstrap component library our components are based on. But this is the bare minimum, a starting point to make the app accessible for visually impaired people. To make the app ready for accessibility use, we need to fulfill the suggestions @bmlancien made.

@bmlancien
Copy link
Contributor Author

After trying to work on that point I came to the conclusion that we are lacking the resources to take care of it, as this topic is quite huge and it is not possible to get into the matter of the subject in just in a few hours...

What we already do/try to do correctly:

  • alt, aria and other attributes and also correct use of HTML5 tags (see Lighthouse)
  • color contrast and use of safe colors for blindness
  • typography with main text 16px (although a big part of items are on 14px, otherwise too difficult to pack everything "nicely" into the app)
  • partially possible to navigate the app with keyboard
  • graphs partially readable through echarts (one screenreader tested out of two was able to read it)

There are still many things to work on. What I see as most difficult right now is the use of a screenreader, but also keyboard navigation, as well as probably other topics that are not covered here.

We will have to keep that issue into the background as hopefully try to focus on that topic on a future project. @nesnoj will check if it is possible to get some more resources for that.

@nesnoj nesnoj added the wontfix 💔 This will not be worked on label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request wontfix 💔 This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants