Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples' naming out of date #109

Open
jnnr opened this issue Jan 13, 2022 · 6 comments
Open

Examples' naming out of date #109

jnnr opened this issue Jan 13, 2022 · 6 comments
Assignees
Milestone

Comments

@jnnr
Copy link
Collaborator

jnnr commented Jan 13, 2022

Some of the values in the examples are not consistent with the rest. This leads to errors when plotting (e.g. snakemake -j1 resutls/base/plotted) Should rename to keep it work.

  • BE -> B
  • liion-battery -> liion_battery
@jnnr jnnr added this to the v0.01 milestone Jan 26, 2022
@jnnr
Copy link
Collaborator Author

jnnr commented Feb 2, 2022

The problem is rather that the script in #93, which defines the regions as constants instead of using the regions of the data.

The problem with liion-battery could not be reproduced.

@jnnr jnnr closed this as completed Feb 2, 2022
@jnnr jnnr reopened this Feb 16, 2022
@jnnr
Copy link
Collaborator Author

jnnr commented Feb 16, 2022

There is a problem with the names of the regions when building the report (the expected regions are hard-coded).

TODO:

  • Adapt the name of the region BE to B in the examples.
  • Adapt the name of the plots BE to B in the reports (report.md and report_interactive.md)

@monika-o
Copy link
Collaborator

monika-o commented Feb 16, 2022

running the report: snakemake -j1 results/base/report/

@monika-o
Copy link
Collaborator

@jnnr The above command results in the error [Errno 2] No such file or directory: 'scenarios/base.yml'. Could it be that the file name in the Snakefile at line 143 is not correct? I am working on the branch fix/BE-to-B which I just created from the dev-branch, so it should be identical to the dev-branch.

@jnnr
Copy link
Collaborator Author

jnnr commented Feb 23, 2022

@jnnr The above command results in the error [Errno 2] No such file or directory: 'scenarios/base.yml'. Could it be that the file name in the Snakefile at line 143 is not correct? I am working on the branch fix/BE-to-B which I just created from the dev-branch, so it should be identical to the dev-branch.

Could be connected to #144

@jnnr jnnr removed this from the v0.0.1 milestone Mar 14, 2022
@jnnr
Copy link
Collaborator Author

jnnr commented Mar 14, 2022

Removed this from the release milestone as it is not ready. Dropped the target rule report_all_examples from Snakefile in 2bba3a1 for now, as the plots do not appear in the report.

@jnnr jnnr added this to the Someday milestone Dec 1, 2022
@MaGering MaGering assigned MaGering and unassigned monika-o Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants